Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): replace ImportError with ModuleNotFoundError #2498

Merged
merged 1 commit into from May 5, 2021

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented May 5, 2021

Using the more specific exception will prevent us from accidentally
ignoring errors that should be handled.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Using the more specific exception will prevent us from accidentally
ignoring errors that should be handled.
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 7f0656f into datahub-project:master May 5, 2021
jjoyce0510 pushed a commit to jjoyce0510/datahub-1 that referenced this pull request Jun 2, 2021
…oject#2498)

Using the more specific exception will prevent us from accidentally
ignoring errors that should be handled.
@hsheth2 hsheth2 deleted the ModuleNotFoundError branch November 10, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants