Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nocode): Final part of No-Code cleanup #3477

Merged
merged 13 commits into from Nov 1, 2021

Conversation

jjoyce0510
Copy link
Collaborator

We still have quite a few files that can be removed since the NoCode initiative a few months back. This PR should clean up lingering files.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Oct 27, 2021

Unit Test Results

     36 files   - 22       36 suites   - 22   23m 21s ⏱️ + 3m 9s
   481 tests  - 44     429 ✔️  - 44  52 💤 ±0  0 ±0 
1 130 runs   - 44  1 062 ✔️  - 44  68 💤 ±0  0 ±0 

Results for commit eef530b. ± Comparison against base commit 9ed0879.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit a92ab66 into datahub-project:master Nov 1, 2021
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Nov 3, 2021
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Nov 6, 2021
shirshanka pushed a commit to shirshanka/datahub that referenced this pull request Nov 6, 2021
@Huyueeer Huyueeer mentioned this pull request Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants