ui: Migrate UI to use "properties" field of entity for descriptions #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
reviewed
Nov 8, 2021
| @@ -40,7 +40,9 @@ export type EntitySidebarSection = { | |||
| export type GenericEntityProperties = { | |||
| urn?: string; | |||
| name?: Maybe<string>; | |||
| description?: Maybe<string>; | |||
| properties?: { | |||
| description?: string; | |||
There was a problem hiding this comment.
should name go here too?
swaroopjagadish
pushed a commit
to swaroopjagadish/datahub
that referenced
this pull request
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates to using the description field of the standard "properties" bag in the GraphQL API, moving away from using the deprecated "info" fields sporadically. It also addresses a few description-rendering related bugs:
This is part of an initiative to more toward convergence of common entity fields to make UI development a simpler proecss.
Checklist