Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(react-app): add default monospace font to font-family #3600

Conversation

robscriva
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Description

This fixes style inconsistency where Roboto Mono isn't installed on the end-users machine. In this instance, it defaults to a serif font. It is defined properly in other parts of the React App codebase

bad
Screen Shot 2021-11-19 at 15 16 35

good
Screen Shot 2021-11-19 at 15 16 41

@github-actions
Copy link

Unit Test Results

     37 files  ±0       37 suites  ±0   28m 34s ⏱️ - 1m 33s
   591 tests ±0     539 ✔️ ±0  52 💤 ±0  0 ±0 
1 330 runs  ±0  1 262 ✔️ ±0  68 💤 ±0  0 ±0 

Results for commit a735fd1. ± Comparison against base commit a36fefa.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for noticing and sending a fix @robscriva :)

@shirshanka shirshanka merged commit dc0d63a into datahub-project:master Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants