Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingestion): Enhance supported and unsupported base_objects_accessed for Snowflake Usage #3608

Conversation

rslanka
Copy link
Contributor

@rslanka rslanka commented Nov 22, 2021

Enhance supported and unsupported base_objects_accessed.
Capture queries from Internal/External stages such as COPY FROM/TO.
SKIP base objects such as S3 locations accessed.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Nov 22, 2021

Unit Test Results

     37 files  ±0       37 suites  ±0   26m 44s ⏱️ - 3m 23s
   591 tests ±0     537 ✔️  - 2  52 💤 ±0  2 +2 
1 328 runs  ±0  1 251 ✔️  - 3  74 💤 ±0  3 +3 

For more details on these failures, see this check.

Results for commit 711867d. ± Comparison against base commit e6b4343.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 314f877 into datahub-project:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants