Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): workaround great-expectations compatibility issue #3634

Merged
merged 1 commit into from Nov 30, 2021
Merged

fix(ingest): workaround great-expectations compatibility issue #3634

merged 1 commit into from Nov 30, 2021

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Nov 29, 2021

Waiting on great-expectations/great_expectations#3758 for a full fix.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results

     44 files  ±0       44 suites  ±0   29m 16s ⏱️ + 2m 22s
   619 tests ±0     567 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
1 358 runs  +2  1 290 ✔️ +8  68 💤  - 6  0 ❌ ±0 

Results for commit 0b6ba65. ± Comparison against base commit de03827.

shirshanka
shirshanka approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 7d5da17 into datahub-project:master Nov 30, 2021
@hsheth2 hsheth2 deleted the ge-version-fix branch November 30, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hsheth2 @shirshanka