fix(deletes): Fixing system metadata index deletes #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-lyons
pushed a commit
to gabe-lyons/datahub
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recently we found that deletion of particular entities was failing, particularly when the entity urn had specific characters in it (like _). The root cause it 2 fold: we were creating elastic doc ids using ASCII which is not sufficiently comprehensive to represent an arbitrary byte string. The other is that we were calling delete twice when deleting system metadata. This PR addresses both issues.
Changes
Validated the changes locally with docker and on k8s deployment.
Checklist