Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest): refactor urn deletion #3694

Merged
merged 2 commits into from Dec 9, 2021
Merged

fix(ingest): refactor urn deletion #3694

merged 2 commits into from Dec 9, 2021

Conversation

kevinhu
Copy link
Contributor

@kevinhu kevinhu commented Dec 8, 2021 •
edited

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Dec 8, 2021 •
edited

Unit Test Results

     44 files  ±0       44 suites  ±0   39m 42s ⏱️ + 11m 22s
   620 tests +1     568 ✔️ +1  52 💤 ±0  0 ❌ ±0 
1 372 runs  +2  1 304 ✔️ +2  68 💤 ±0  0 ❌ ±0 

Results for commit 217d16f. ± Comparison against base commit 1a5121a.

♻️ This comment has been updated with latest results.

@kevinhu kevinhu marked this pull request as ready for review December 8, 2021 20:35
shirshanka
shirshanka approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 15ed3ae into datahub-project:master Dec 9, 2021
gabe-lyons pushed a commit to gabe-lyons/datahub that referenced this pull request Dec 9, 2021
@kevinhu
refactor(ingest): cli deletion function (datahub-project#3694)
a1ce815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinhu @shirshanka