Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(url encoding): also encode square brackets #3709

Merged
merged 1 commit into from Dec 10, 2021
Merged

fix(url encoding): also encode square brackets #3709

merged 1 commit into from Dec 10, 2021

Conversation

gabe-lyons
Copy link
Contributor

We didn't encode square brackets in our encode method. this created problems because square brackets are used in spark streaming entity urns.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@gabe-lyons
Copy link
Contributor Author

tested with:

image

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Unit Test Results

     44 files  ±0       44 suites  ±0   40m 58s ⏱️ + 2m 4s
   621 tests ±0     569 ✔️ ±0  52 💤 ±0  0 ❌ ±0 
1 377 runs  ±0  1 309 ✔️ ±0  68 💤 ±0  0 ❌ ±0 

Results for commit 7f3855f. ± Comparison against base commit bd4ecbc.

shirshanka
shirshanka approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit 1056058 into datahub-project:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gabe-lyons @shirshanka