Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): Fix issue with filters and autocomplete #3868

Merged
merged 8 commits into from Jan 12, 2022

Conversation

dexter-mh-lee
Copy link
Contributor

Fix issue with filters where it is overmatching result by appending .keyword to filters in graphql
Slack thread: https://datahubspace.slack.com/archives/C029A3M079U/p1639775100480300

Fix issue with autocomplete where it is again overmatching. It returns results that match at least one of the tokens instead of matching all the tokens.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Jan 11, 2022

Unit Test Results (build & test)

  45 files    45 suites   17m 34s ⏱️
502 tests 450 ✔️ 52 💤 0

Results for commit 4da7aa1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirshanka shirshanka merged commit b586092 into datahub-project:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants