Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refining Metadata Model docs further #4001

Merged

Conversation

jjoyce0510
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

Unit Test Results (build & test)

  66 files    66 suites   12m 38s ⏱️
579 tests 519 ✔️ 59 💤 0  1 🔥

For more details on these errors, see this check.

Results for commit b0af825.

@github-actions
Copy link

Unit Test Results (metadata ingestion)

       5 files         5 suites   36m 23s ⏱️
   275 tests    274 ✔️   0 💤 1
1 266 runs  1 235 ✔️ 30 💤 1

For more details on these failures, see this check.

Results for commit b0af825.

@shirshanka shirshanka merged commit 3c2a4fe into datahub-project:master Jan 28, 2022
entityUrn=builder.make_dataset_urn("bigquery", "downstream"),
aspectName="upstreamLineage",
aspect=upstream_lineage,
systemMetadata=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjoyce0510 looks like there's some code missing here? Seems to be causing test failures

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Addressing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants