fix(analytics): fix missing events from UI #4026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjoyce0510
reviewed
Feb 1, 2022
| @@ -55,6 +55,10 @@ task yarnLint(type: YarnTask, dependsOn: [yarnInstall, yarnGenerate]) { | |||
| args = ['run', 'lint'] | |||
| } | |||
|
|
|||
| task yarnLintFix(type: YarnTask, dependsOn: [yarnInstall, yarnGenerate]) { | |||
jjoyce0510
reviewed
Feb 1, 2022
| @@ -117,7 +117,7 @@ export default function TagTermGroup({ | |||
| const termToRemove = editableGlossaryTerms?.terms?.find((term) => term.term.urn === urnToRemove); | |||
| Modal.confirm({ | |||
| title: `Do you want to remove ${termToRemove?.term.name} term?`, | |||
| content: `Are you sure you want to remove the ${termToRemove?.term.name} tag?`, | |||
| content: `Are you sure you want to remove the ${termToRemove?.term.name} term?`, | |||
jjoyce0510
approved these changes
Feb 1, 2022
shirshanka
approved these changes
Feb 7, 2022
aditya-radhakrishnan
pushed a commit
to aditya-radhakrishnan/datahub
that referenced
this pull request
Feb 7, 2022
ne1r0n
pushed a commit
to ne1r0n/datahub
that referenced
this pull request
Feb 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist