Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add --force option to ingest rollback subcommand #4032

Conversation

danilopeixoto
Copy link
Contributor

This pull request adds the --force option to ingest rollback subcommand allowing users to run it in environments like JupyterLab cell.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Unit Test Results (build & test)

  68 files    68 suites   10m 14s ⏱️
589 tests 530 ✔️ 59 💤 0

Results for commit 55824e1.

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

Unit Test Results (metadata ingestion)

       5 files         5 suites   40m 54s ⏱️
   279 tests    279 ✔️   0 💤 0
1 284 runs  1 255 ✔️ 29 💤 0

Results for commit 55824e1.

@shirshanka shirshanka merged commit 52272d6 into datahub-project:master Feb 6, 2022
aditya-radhakrishnan pushed a commit to aditya-radhakrishnan/datahub that referenced this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants