Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deprecation): Entity Deprecation Backend #4073

Merged

Conversation

jjoyce0510
Copy link
Collaborator

Summary
This PR introduces entity deprecation for datasets, charts, dashboards, data flows, glossary terms in the model + GraphQL API layer.

Changes

  • Added Deprecation aspect to relevant entities GMS + GraphQL models.
  • Fetch deprecation aspect in "get" GraphQL Type classes.

Status
Verified manually. Resolver Test, smoke test coming.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Unit Test Results (build & test)

  69 files  +1    69 suites  +1   14m 7s ⏱️ + 4m 41s
604 tests +8  545 ✔️ +8  59 💤 ±0  0 ±0 

Results for commit cac9561. ± Comparison against base commit 2a9a076.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Unit Test Results (metadata ingestion)

    3 files  ±0      3 suites  ±0   39m 30s ⏱️ - 4m 36s
303 tests ±0  303 ✔️ ±0    0 💤 ±0  0 ±0 
869 runs  ±0  842 ✔️ ±0  27 💤 ±0  0 ±0 

Results for commit cac9561. ± Comparison against base commit 2a9a076.

♻️ This comment has been updated with latest results.

@shirshanka shirshanka merged commit 8002fd8 into datahub-project:master Feb 8, 2022
ne1r0n pushed a commit to ne1r0n/datahub that referenced this pull request Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants