Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): Add display name & title to editable corp user properties. #4097

Merged
merged 1 commit into from Feb 9, 2022
Merged

feat(ui): Add display name & title to editable corp user properties. #4097

merged 1 commit into from Feb 9, 2022

Conversation

jjoyce0510
Copy link
Collaborator

...For display name and title authored natively on datahub.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

gabe-lyons
gabe-lyons approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Unit Test Results (metadata ingestion)

    3 files      3 suites   39m 40s ⏱️
303 tests 303 ✔️   0 💤 0 ❌
869 runs  842 ✔️ 27 💤 0 ❌

Results for commit 3423b78.

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Unit Test Results (build & test)

  69 files  ±0    69 suites  ±0   17m 27s ⏱️ + 2m 54s
604 tests ±0  544 ✔️ ±0  59 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 3423b78. ± Comparison against base commit a0a2e02.

@shirshanka shirshanka merged commit 0f56bc5 into datahub-project:master Feb 9, 2022
ne1r0n pushed a commit to ne1r0n/datahub that referenced this pull request Feb 13, 2022
@jjoyce0510 @ne1r0n
Adding extra properties to corp user editable info (datahub-project#4097
661ed13 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jjoyce0510 @shirshanka @gabe-lyons