Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs) Fix doc on modelDocUpload #4112

Merged
merged 1 commit into from Feb 11, 2022
Merged

fix(docs) Fix doc on modelDocUpload #4112

merged 1 commit into from Feb 11, 2022

Conversation

daha
Copy link
Contributor

@daha daha commented Feb 10, 2022

Update the doc to use the same environment variable as the script
to configure which Datahub server to upload the model doc to.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

@daha
fix(docs) Fix doc on modelDocUpload
ed498dd 
Update the doc to use the same environment variable as the script
to configure which Datahub server to upload the model doc to.
shirshanka
shirshanka approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution

@shirshanka shirshanka merged commit 6c214ad into datahub-project:master Feb 11, 2022
@daha daha deleted the fix-modelDocUpload-doc branch February 11, 2022 21:54
ne1r0n pushed a commit to ne1r0n/datahub that referenced this pull request Feb 13, 2022
@daha @ne1r0n
fix(docs) Fix doc on modelDocUpload (datahub-project#4112)
ca74460 
Update the doc to use the same environment variable as the script
to configure which Datahub server to upload the model doc to.
hevandro-veiga pushed a commit to hevandro-veiga/datahub that referenced this pull request Feb 18, 2022
@daha @hevandro-veiga
fix(docs) Fix doc on modelDocUpload (datahub-project#4112)
c401177 
Update the doc to use the same environment variable as the script
to configure which Datahub server to upload the model doc to.
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@daha @maggiehays
fix(docs) Fix doc on modelDocUpload (datahub-project#4112)
511890f 
Update the doc to use the same environment variable as the script
to configure which Datahub server to upload the model doc to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shirshanka shirshanka shirshanka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daha @shirshanka