Fix the type of default values to match what Schema.parse() does. #3611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling field.defaultVal() (or equivalent compat helper methods)
under Avro 1.9.2+, we get back a type that's not consistent with what
Schema.parse() creates internally. This causes two Schemas constructed
in these two different ways (Schema.parse vs Schema.createRecord) to
be considered unequal, even though their toString() representations
are identical.
Fix this situation by calling parseJsonToObject(), which results in
the default value being interpreted similar to Schema.parse().
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Tests
Commits