add center option for arrowOffset

LinkedInAttic · Jun 5, 2013 · be5f972 · be5f972
1 parent a6f0962
commit be5f972
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 35 deletions.
diff --git a/js/hopscotch-0.1.js b/js/hopscotch-0.1.js
@@ -568,11 +568,11 @@
           boundingRect,
           top,
           left,
+          arrowOffset,
           bubbleBorder = 6,
           targetEl     = utils.getStepTarget(step),
           el           = this.element,
-          arrowEl      = this.arrowEl,
-          arrowOffset  = utils.getPixelValue(step.arrowOffset);
+          arrowEl      = this.arrowEl;
 
       bubbleWidth   = utils.getPixelValue(step.width) || this.opt.bubbleWidth;
       bubblePadding = utils.valOrDefault(step.padding, this.opt.bubblePadding);
@@ -605,17 +605,36 @@
       }
 
       // SET (OR RESET) ARROW OFFSETS
+      if (step.arrowOffset !== 'center') {
+        arrowOffset = utils.getPixelValue(step.arrowOffset);
+      }
+      else {
+        arrowOffset = step.arrowOffset;
+      }
       if (!arrowOffset) {
         arrowEl.style.top = '';
         arrowEl.style.left = '';
       }
       else if (step.placement === 'top' || step.placement === 'bottom') {
         arrowEl.style.top = '';
-        arrowEl.style.left = arrowOffset + 'px';
+        if (arrowOffset === 'center') {
+          arrowEl.style.left = bubbleWidth/2 - this.opt.arrowWidth/2 + 'px';
+        }
+        else {
+          // Numeric pixel value
+          arrowEl.style.left = arrowOffset + 'px';
+        }
       }
       else if (step.placement === 'left' || step.placement === 'right') {
         arrowEl.style.left = '';
-        arrowEl.style.top = arrowOffset + 'px';
+        if (arrowOffset === 'center') {
+          bubbleHeight = bubbleHeight || el.offsetHeight;
+          arrowEl.style.top = bubbleHeight/2 - this.opt.arrowWidth/2 + 'px';
+        }
+        else {
+          // Numeric pixel value
+          arrowEl.style.top = arrowOffset + 'px';
+        }
       }
 
       // HORIZONTAL OFFSET