Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack normalization issue and "Other" needs to verify if we can operate on the stack, else return e.message. #301

Closed
riksidhu opened this issue Apr 10, 2014 · 3 comments · Fixed by #302

Comments

@riksidhu
Copy link

Example

else if (e.stack && e.number) {
return 'ie';
}

"it should be"

else if (e.stack && typeof e.number == 'number') {

    return 'ie';

}

@jakobo
Copy link
Contributor

jakobo commented Apr 10, 2014

Thanks for reporting this Ricky. We will verify this is fixed as part of
the 0.7.0 cycle

On Thursday, April 10, 2014, ricky sidhu notifications@github.com wrote:

Example

else if (e.stack && e.number) {
return 'ie';
}

"it should be"

else if (e.stack && typeof e.number == 'number') {

return 'ie';

}

Reply to this email directly or view it on GitHubhttps://github.com//issues/301
.

--Jakob

@riksidhu
Copy link
Author

Thank you Jakob!

@jakobo
Copy link
Contributor

jakobo commented Apr 21, 2014

Closing this. The fix resides in pull request #302 now

@jakobo jakobo closed this as completed Apr 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants