Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: aggregated messages will lose their original message body #131

Closed
houqp opened this issue Apr 20, 2017 · 1 comment
Closed

Bug: aggregated messages will lose their original message body #131

houqp opened this issue Apr 20, 2017 · 1 comment
Labels

Comments

@houqp
Copy link
Contributor

houqp commented Apr 20, 2017

Currently, if a message is aggregated, the original body will get reset to a `Batch ID: HASH' due to the following line:

sql = SENT_MESSAGE_BATCH_SQL % connection.escape(message['aggregated_ids'])

Ideally, we should keep the content of the original messages unchanged and create a new message specifically for the batch notification.

@houqp houqp added the bug label Apr 20, 2017
@houqp
Copy link
Contributor Author

houqp commented May 2, 2017

We should also include help text in the message to let user know how to get all the batched messages using the ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants