Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Jolokia port/url configurable ( in JolokiaService and in webapp/index.html ) #113

Closed
andlaz opened this issue Mar 9, 2018 · 1 comment

Comments

@andlaz
Copy link

andlaz commented Mar 9, 2018

Hi,

i had a requirement to deploy kafka-monitor in kubernetes, and expose JettyService ( specifically, the small js ui that draws a couple graphs ) and JolokiaService over an ingress.

In the current master branch this is rather difficult because index.html hardcodes the jolokia port/url as http:// + location.host.split(':')[0] + :8778/jolokia , with the port also hardcoded in JolokiaService.

I will be sending a PR for your review to discuss/potentially fix these issues.

thanks!
Andras

@andrewchoi5
Copy link
Contributor

Hi Andlaz, it seems as though there already is a Pull Request that is ongoing and in progress, Thus, could I close this issue? Thanks! 😄

@andrewchoi5 andrewchoi5 self-assigned this Dec 11, 2019
@andrewchoi5 andrewchoi5 added this to the Improvements milestone Dec 11, 2019
@andrewchoi5 andrewchoi5 added this to To do in Xinfra Monitor via automation Dec 12, 2019
Xinfra Monitor automation moved this from To do to Done Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants