Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new email template #1124

Merged
merged 3 commits into from Mar 8, 2017
Merged

Conversation

justYves
Copy link
Contributor

@justYves justYves commented Mar 8, 2017

what's new:

  • new email template v2
  • added phantomJs script for screenshots
  • reenabling the root cause analysis tab for the launch (will be used as temporary placeholder for investigate)

JIRA:

Screenshots:

screen shot 2017-03-07 at 10 46 38 pm

screen shot 2017-03-07 at 10 46 50 pm

@justYves justYves self-assigned this Mar 8, 2017
<head>
</head>
<body>
<table border="0" cellpadding="0" cellspacing="0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline styling everywhere :( internal stylesheets doesn't work for mobile mail apps

var page = require('webpage').create();
var system = require('system');
var args = require('system').args;
var options = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no es6, phantomjs doesn't support it

@justYves justYves changed the title added template new email template Mar 8, 2017
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Ship it.

@justYves justYves merged commit 7d1c707 into apache:master Mar 8, 2017
Copy link

@luisah luisah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@justYves justYves deleted the yyuen/new_email_template branch April 27, 2017 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants