Removing all restlet stuff from code #1833
Conversation
Only test deleted so far is LLCSegmentCommit unit test.
Codecov Report
@@ Coverage Diff @@
## master #1833 +/- ##
==========================================
+ Coverage 66.18% 68.78% +2.59%
==========================================
Files 885 853 -32
Lines 42716 40673 -2043
Branches 5615 5318 -297
==========================================
- Hits 28273 27977 -296
+ Misses 12565 10839 -1726
+ Partials 1878 1857 -21
Continue to review full report at Codecov.
|
|
Love the code coverage improvement 👍 |
There was a problem hiding this comment.
One comment around removing todo. All other comments here and on review are optional
pinot-common/ restlet folder, package com.linkedin.pinot.common.restlet.swagger, has multiple annotations defined that are not used anymore. We can drop those as well.
Our top level NOTICE file has notice about restlet. We can remove that.
(optional) We should also drop the word restlet from jersey class names now
| @@ -248,26 +248,6 @@ | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
this pom has a restlet repository. We can remove that now
| component.getServers().add(Protocol.HTTP, restletPort); | ||
| component.getClients().add(Protocol.FILE); | ||
| component.getClients().add(Protocol.JAR); | ||
| Context applicationContext = component.getContext().createChildContext(); | ||
| LOGGER.info("Controller download url base: {}", config.generateVipUrl()); | ||
| LOGGER.info("Injecting configuration and resource managers to the API context"); | ||
| // TODO: Remove attributes map when removing restlet |
There was a problem hiding this comment.
we can drop the todo now that you have addressed it
| @@ -81,8 +72,6 @@ | |||
|
|
|||
| public ControllerStarter(ControllerConf conf) { | |||
| config = conf; | |||
| component = new Component(); | |||
| controllerRestApp = new ControllerRestApplication(config.getQueryConsole()); | |||
There was a problem hiding this comment.
(optional) The executorservice threads are named as 'restlet....'. We can change that to avoid possible confusion
Had to remove one annotation in pojos/Instance.java to get things to compile.
Removed all references to restlet, including pom files.
Had to remove the LLCSegmentCommitTest since that was using the internals of restlet mechanism to verify the code.