Print message in TableSizeReader only when num of errors > 0 #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2990 +/- ##
==========================================
- Coverage 69.93% 69.89% -0.05%
==========================================
Files 913 913
Lines 43288 43289 +1
Branches 5917 5918 +1
==========================================
- Hits 30274 30257 -17
- Misses 10984 10999 +15
- Partials 2030 2033 +3
Continue to review full report at Codecov.
|
| LOGGER.info("Could not get size for segment {} from {} servers. Using segmentLevelMax {} to estimate the size", | ||
| segmentEntry.getKey(), errors, segmentLevelMax); | ||
| if (errors > 0) { | ||
| // at least one server reported size for this segment |
There was a problem hiding this comment.
Move the comment outside of the if-block.
sunithabeeram
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it prints the message even when there's no error.
Adding this if statement can help reduce most of the noises in controller log.