Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Windows #9

Closed
gengjiawen opened this issue Sep 12, 2015 · 10 comments
Closed

Support for Windows #9

gengjiawen opened this issue Sep 12, 2015 · 10 comments
Assignees
Labels
enhancement A feature request.

Comments

@gengjiawen
Copy link

I am using python 2.7.10, but I can't get thing worked.Is this a compatible problem?

d:\Developer\CodeReview\qark>C:\Python27\python.exe qark.py
Traceback (most recent call last):
  File "qark.py", line 24, in <module>
    from modules import common,intents,webviews, report, unpackAPK
  File "d:\Developer\CodeReview\qark\modules\common.py", line 26, in <module>
    from lib.blessed import *
  File "d:\Developer\CodeReview\qark\lib\blessed\__init__.py", line 12, in <modu
    from terminal import Terminal
  File "d:\Developer\CodeReview\qark\lib\blessed\terminal.py", line 7, in <modul
    import termios
ImportError: No module named termios
@gengjiawen gengjiawen changed the title Support for python 3 or python 2.7.10 Support for Windows Sep 12, 2015
@tushardalvi
Copy link
Contributor

We only currently support OSX and Ubuntu Linux (Other versions of Linux may work, but are not supported). For now, we recommend running it in a VM if you are on Windows.

We are working on making QARK cross compatible across OSX/Linux/Windows.

@tushardalvi tushardalvi self-assigned this Sep 12, 2015
@einhverfr
Copy link

I have been looking into what is required to do this. It looks like the entire terminal subsystem assumes you have curses, termios, fctl, and tty support and this leads to some significant issues when it comes with Windows.

Since if I contribute code to help this process along I would like it to be incorporated in the main project I figure it is worth asking first if any approach has been decided on. If not it seems like either the blessed/* modules would need to be rewritten or a separate Windows implementation of related funtionality would need to be added.

Any thoughts before I begin?

@einhverfr
Copy link

Ok lookig at the code more, it looks like the plan was to use colorama libraries (included in the code tree) to get this to work? I notice there is no real effort to integrate it into the actual terminal subsystem yet. so that looks like the way to go.

@SecBro1
Copy link

SecBro1 commented Dec 28, 2015

@einhverfr , sorry for the delayed response. We're not currently working on Windows support, so please, by all means contribute this!

@einhverfr
Copy link

@SecBro1

Thanks!

My current approach is to require pdcurses for Windows, and then to wrap some of the Posix terminal capacity in porting layers. It isn't clear to me whether on top of this, colorama, etc, is actually required. I hope to know more in a few days.

@einhverfr
Copy link

With PR #26 Qark runs well enough to find platform specific problems. It is not good enough I would advertise Windows support just yet but it is good enough that people who want to help can get going and try to make things work.

@einhverfr
Copy link

As a note on Pr #26 and this issue. I am still having a few issues. I think the Windows support for the python-pdcurses wrapper may be incomplete enough to pose some usability issues.

I am having some issues setting up the android sdk. I think this is a Windows-specific multi-processing I/O issue. I expect to have this fixed in some way this week.

However with that PR, the software loads and completes the static analysis despite the UI issues.

I am currently looking into how to resolve the above two issues. However, code feedback, if the PR is not acceptable would be helpful.

@einhverfr
Copy link

PR #26 is now about as far as I feel comfortable taking it without further review and hopefullly acceptance.

There is one final UI issue that occurs that I know of but fixing it is likely to be something that needs to be thought about on its own. The problem is that things are done in a very POSIX-y way which is semantically incompatible with the way Windows consoles work.

So please review it. I am happy to make whatever changes are needed to get it accepted.

@SecBro1 SecBro1 added the enhancement A feature request. label Apr 16, 2016
@nwalsh-lnk
Copy link
Contributor

We have just pushed a new version of QARK that solves a lot of problems and enhances the code.

As a result we will be closing out all tickets for the older version since we no longer support it. If this issue persists in the new version please create a new ticket.

@jquast
Copy link

jquast commented May 1, 2020

I thought I'd let you know that blessed supports windows directly, I see your tree is just an old copy that has been customized to support windows, that's fine too, just thought you'd like to know this was solved upstream and there is no need to fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature request.
Projects
None yet
Development

No branches or pull requests

6 participants