Add x-sepia-test-name header support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README.md explains the rationale and mechanism behind this feature.
|
|
||
| var filtered = {}; | ||
|
|
||
| for (var key in headers) { |
There was a problem hiding this comment.
Use lodash _.pick instead.
There was a problem hiding this comment.
sepia has no non-development dependencies. Even lodash is only as a dev dependency.
In any case, _.pick wouldn't work because what we're looking for is actually _.filter. or _.reject.
deepankgupta
added a commit
that referenced
this pull request
Dec 24, 2013
Add x-sepia-test-name header support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README.md explains the rationale and mechanism behind this feature.