Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onLoad times are incorrect sometimes #28

Open
RiteshMaheshwari opened this issue Feb 5, 2013 · 11 comments
Open

onLoad times are incorrect sometimes #28

RiteshMaheshwari opened this issue Feb 5, 2013 · 11 comments

Comments

@RiteshMaheshwari
Copy link
Contributor

mobster-waterfall-bug

See the attachment. I think this is a bug with chromium, but if they are not able to solve it, we need a way to detect and resolve this in mobster. One potential approach is to look at the start time of the page requested and ignore stuff before it (in the har/waterfall)

@armanhb
Copy link
Contributor

armanhb commented Feb 5, 2013

Interesting, do the 2 files at the top of the waterfall actually belong to the request?

@RiteshMaheshwari
Copy link
Contributor Author

Yes.

@RiteshMaheshwari
Copy link
Contributor Author

Those 2 calls are usually at the very end on this page.

@RiteshMaheshwari
Copy link
Contributor Author

Potentially an issue with chromium: http://code.google.com/p/chromium/issues/detail?id=141971

@RiteshMaheshwari
Copy link
Contributor Author

One of the potential issues could be related to how much time is mobster waiting after onLoad before starting the next iterations. If we don't wait long enough, the javascript calls after onLoad might pollute the timings in the next iteration.

@armanhb
Copy link
Contributor

armanhb commented Apr 10, 2013

I agree. It would be great if we could simply kill all javascript activity
after determining that the page has "loaded" but after skimming the webkit
protocol it doesn't look like there is a way to do it.

On Tue, Apr 9, 2013 at 4:46 PM, RiteshMaheshwari
notifications@github.comwrote:

One of the potential issues could be related to how much time is mobster
waiting after onLoad before starting the next iterations. If we don't wait
long enough, the javascript calls after onLoad might pollute the timings in
the next iteration.


Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-16147456
.

@armanhb
Copy link
Contributor

armanhb commented Apr 10, 2013

Never mind, that wouldn't work either...

On Tue, Apr 9, 2013 at 10:13 PM, Arman Boehm armanhb@gmail.com wrote:

I agree. It would be great if we could simply kill all javascript activity
after determining that the page has "loaded" but after skimming the webkit
protocol it doesn't look like there is a way to do it.

On Tue, Apr 9, 2013 at 4:46 PM, RiteshMaheshwari <notifications@github.com

wrote:

One of the potential issues could be related to how much time is mobster
waiting after onLoad before starting the next iterations. If we don't wait
long enough, the javascript calls after onLoad might pollute the timings in
the next iteration.


Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-16147456
.

@RiteshMaheshwari
Copy link
Contributor Author

I guess my question is (I haven't looked at the code), do we wait X seconds after onLoad before starting the next iteration? If so, lets make it 2X or 3X and see if that fixes it.

@hariramachandra
Copy link
Contributor

Ritesh, Arman

 If it helps we can get on a conf call to discuss the issue. ( might be faster )

thanks
Hari


From: RiteshMaheshwari notifications@github.com
To: linkedin/mobster mobster@noreply.github.com
Sent: Wednesday, April 10, 2013 6:09 AM
Subject: Re: [mobster] onLoad times are incorrect sometimes (#28)

I guess my question is (I haven't looked at the code), do we wait X seconds after onLoad before starting the next iteration? If so, lets make it 2X or 3X and see if that fixes it.

Reply to this email directly or view it on GitHub.

@anantrao
Copy link

Hey Arman,

There are 2 events of the browser which can be leveraged

  1. onBeforeUnload
  2. unLoad.

We should do all the parsing/processing after the onBeforeUnload event , do a check at unload event

$(window).onBeforeunload(function() {
//do all the processing
});

$(window).unload(function() {
//kill all JS activity and ensure the previous step is done.
});

In summary for waterfall processing , we should do it after the onBeforeUnload have fired, else they wont line up and
will ensure sanity.

we can have a call to discuss in detail

@armanhb
Copy link
Contributor

armanhb commented Apr 11, 2013

Sounds good I'll send you guys an email to set up the call.

On Wed, Apr 10, 2013 at 3:04 PM, anantrao notifications@github.com wrote:

Hey Arman,

There are 2 events of the browser which can be leveraged

  1. onBeforeUnload
  2. unLoad.

We should do all the parsing/processing after the onBeforeUnload event ,
do a check at unload event

$(window).onBeforeunload(function() {
//do all the processing
});

$(window).unload(function() {
//kill all JS activity and ensure the previous step is done.
});

In summary for waterfall processing , we should do it after the
onBeforeUnload have fired, else they wont line up and
will ensure sanity.

we can have a call to discuss in detail


Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-16205374
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants