Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SecurityContext to the various containers installed, except the initContainer #1930

Closed
codeman9 opened this issue Dec 5, 2018 · 2 comments

Comments

@codeman9
Copy link
Contributor

codeman9 commented Dec 5, 2018

Feature Request

What problem are you trying to solve?

Our Pod Security Policy explicitly denies containers running as root. Since the Dockerfiles for the various containers needed during linkerd install do not specify a user, it is assumed that they will run as root. When I try to install linkerd into our cluster, I get an error that says that containers cannot runAsRoot. The initContainer that needs root and NET_ADMIN will still be an issue for us until #1887 is resolved.

How should the problem be solved?

Adding a securityContext with a runAsUser value to the various containers is one way to solve this problem. If any of the required containers do actually need to run as root, then I'm not sure how to get around that. From what I can tell this change doesn't affect the installation.

Any alternatives you've considered?

I'm not super familiar with alternatives other than updating the Dockerfiles to run as a particular user.

How would users interact with this feature?

Users will not be affected by this change.

@codeman9
Copy link
Contributor Author

codeman9 commented Dec 5, 2018

#1929

@codeman9 codeman9 changed the title Add SecurityContext to the various containers installed Add SecurityContext to the various containers installed, except the initContainer Dec 10, 2018
@klingerf
Copy link
Member

Fixed by #1929.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants