Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tap shortcut to route metrics table #2106

Open
grampelberg opened this issue Jan 17, 2019 · 1 comment
Open

Add tap shortcut to route metrics table #2106

grampelberg opened this issue Jan 17, 2019 · 1 comment

Comments

@grampelberg
Copy link
Contributor

What problem are you trying to solve?

When looking at live metrics, it is super useful to link over to tap.

How should the problem be solved?

It would be great if there was a tap icon on the route metrics table as well.

@klingerf
Copy link
Member

(apologies, this is very low priority, but have been meaning to comment, so here goes)

Route metrics are grouped by service, but it's not possible to tap a service. I think the best way to go about surfacing tap data for a route would be to update the tap API to support filtering by routes, and then wire up support for route filtering in the CLI and web UI. With that in place, we could add a tap icon link in the routes table on a resource detail page to the tap page, and on click we could pre-populate the current resource and selected route in the tap query form and kick off the tap.

Shorter version of that is: I'd like to see this feature too, but it might be non-trivial to map route data to tap data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants