New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Support kubectl-style resource selectors #2734
Comments
I would like to work on this. |
@VineethReddy02 go for it! Any pointers we can give to help out? |
@VineethReddy02 @grampelberg Is this still being worked on? I'd like to take up this one if that's okay :) |
@mayankshah1607 let's give @VineethReddy02 a little bit, but I'm unaware of anyone actively working on this one. |
Hi @mayankshah1607 you can take this up. I am occupied at this moment. |
Hi @mayankshah1607, are you still working on this? If not I would like to have a go at this one. EDIT: I saw that some PRs were already merged, is this issue still relevant? If so, what remains to be implemented? |
@shidenkai0 It looks like #4183 was a created to track the remaining work. That was closed because it staled out — not because the work was completed. You should be able to reference that issue for adding what is left if you are interested! |
According to #4183, the remaining commands that need to be updated are:
|
has this issue been solved ? if no can i work on this? |
@itsCheithanya the issues listed in the bullet points above are still open so you're free to work on this if you'd like. |
The various Linkerd subcommands that operate on kubernetes resources all work somewhat differently, and none of them support Kubernetes label selection.
Anywhere where the
linkerd
CLI operates on a list of resources (tap
,top
,routes
,stat
,metrics
, etc),linkerd
should accept resource selections exactly likekubectl
.Furthermore the
--linkerd-namespace
flag should be changed so that its short flag is-L
, so that the-l
flag can be used for label selection (like other kubernetes-related tools).For example, kubectl supports the following:
linkerd
should accept resource lists similarly.linkerd stat
accepts multiple resources, like kubectl, but does not accept label selectors:linkerd tap
,linkerd top
, andlikerd routes
do not accept a list of resourcesBut there is no technical reason for this, since they all accept all resources of a given type:
The
linkerd metrics
command does not accept any resource lists, though it supports expanding group typeslike deploy/foo
.The text was updated successfully, but these errors were encountered: