Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The UI doesn't indicate whether a pod can have the proxy injected into it or why not #385

Closed
briansmith opened this issue Feb 17, 2018 · 2 comments

Comments

@briansmith
Copy link
Contributor

Consider a pod that has hostNetwork: true (see #366) or another reason (see #62 for example) why we might not inject the proxy into the pod. In that case, the UI will show the pod as "not in the service mesh." However, I think it would be useful if the UI showed the pod in a different state that indicates that it requires work beyond just doing conduit inject to get it into the service mesh.

Consider also the case where a pod has an explicit annotation (which we don't support yet, but we might eventually) that explicitly indicates the proxy shouldn't be injected and/or that we shouldn't do any proxying for the pod (we already support this with our port skipping options for conduit inject but this isn't persistent in the pod specs yet). The UI should somehow show these explicitly-opting-out pods differently.

Similarly, when conduit inject or equivalent is run and we skip some pods for the above reasons, we might want to output (perhaps only in "verbose" mode) messages indicating that we're skipping the pod spec and all the reasons why we're skipping it.

@briansmith
Copy link
Contributor Author

Similarly, the documentation should reflect these choices.

@olix0r olix0r removed the usability label Mar 13, 2018
@stale
Copy link

stale bot commented Oct 7, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 7, 2018
@stale stale bot closed this as completed Oct 23, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants