Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy exposes Prometheus protobuf metrics #541

Closed
hawkw opened this issue Mar 8, 2018 · 1 comment
Closed

Proxy exposes Prometheus protobuf metrics #541

hawkw opened this issue Mar 8, 2018 · 1 comment
Labels
Milestone

Comments

@hawkw
Copy link
Member

hawkw commented Mar 8, 2018

The proxy metrics endpoint (added in #540) should also expose metrics in the Prometheus Protocol Buffers format. Whether to serve text metrics or protobuf should be determined based on the request's content type, with text/plain requests receiving text metrics and application/vnd.google.protobuf; proto=io.prometheus.client.MetricFamily; encoding=delimited requests receiving protobuf metrics.

@hawkw
Copy link
Member Author

hawkw commented Mar 13, 2018

According to the Prometheus documentation:

NOTE: Prometheus 2.0 removed support for the protocol-buffer format and only supports the text-based format.

Are we still interested in supporting the protocol buffer format? We might want to for non-Prometheus 2.0 installations, but removing support for this could potentially make our metrics implementation much more efficient (as prost requires a lot of things to be Vecs or Strings that could otherwise be non-allocating).

@hawkw hawkw closed this as completed Mar 13, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants