Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Helm experience #375

Merged
merged 1 commit into from Jul 19, 2022

Conversation

WyriHaximus
Copy link
Contributor

Since the deprecation of the stable Helm chart repository by Helm, chaoskube's chart is one of the charts I've been waiting for to be ported.

Initially, when that happened I didn't get it to work and didn't look too deep into it. Now that I'm building a home cluster it came up again,
and after looking into it properly there are a few things that came up:

  • The project's readme still lists the old stable Helm chart repository.
  • The chart's readme lists a non-existent (?) Helm chart repository
  • Has default values for arguments causing issues for some of those when empty
  • Missing v for the default tag
  • Using a non-amd64 OCI image on a raspberry pi was a bit of a search to find out and get working

P.S. This PR only aims to make it work out of the box again and contains some breaking changes causing the major version bump.

@@ -45,7 +45,8 @@ INFO[4804] terminating pod name=nginx-701339712-51nt8 namespace=chaosku
You can install `chaoskube` with [`Helm`](https://github.com/kubernetes/helm). Follow [Helm's Quickstart Guide](https://helm.sh/docs/intro/quickstart/) and then install the `chaoskube` chart.

```console
$ helm install stable/chaoskube
$ helm repo add chaoskube https://linki.github.io/chaoskube/
$ helm install chaoskube chaoskube/chaoskube --atomic --namespace=chaoskube --create-namespace

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old instructions got me initially too. New instructions will be helpful for new users 👍

@zwhite
Copy link

zwhite commented Mar 4, 2022

I was just tracking down why it is I can't get chaoskube to start in Dry Run mode, and this PR would fix it for me. Would help me a lot to get this in.

Edit: For anyone else who is stuck you can use no-dry-run: null to override the current default.

@linki
Copy link
Owner

linki commented Jul 12, 2022

@WyriHaximus Thanks a lot for this PR.

Meanwhile I migrated the docker images from quay.io/linki/chaoskube to ghcr.io/linki/chaoskube. The new image on ghcr.io is a multi-arch image so we could remove the need for handling the architecture.

@WyriHaximus Would you mind updating the image in this PR and removing the architecture related part?

@WyriHaximus WyriHaximus force-pushed the improve-helm-experience branch 2 times, most recently from d2af3bf to 871fce9 Compare July 12, 2022 15:28
Since the deprecation of the `stable` Helm chart repository by Helm, chaoskube's chart is one of the charts I've been waiting for to be ported.

Initially, when that happened I didn't get it to work and didn't look too deep into it. Now that I'm building a home cluster it came up again,
and after looking into it properly there are a few things that came up:

- [X] The project's readme still lists the old `stable` Helm chart repository.
- [X] The chart's readme lists a non-existent (?) Helm chart repository
- [X] Has default values for arguments causing issues for some of those when empty
- [X] Missing `v` for the default tag

P.S. This PR only aims to make it work out of the box again and contains some breaking changes causing the major version bump.
@WyriHaximus
Copy link
Contributor Author

@WyriHaximus Thanks a lot for this PR.

@linki 👍 , also rebased this PR on the latest master

Meanwhile I migrated the docker images from quay.io/linki/chaoskube to ghcr.io/linki/chaoskube. The new image on ghcr.io is a multi-arch image so we could remove the need for handling the architecture.

Awesome, updated the chart with the new repository and confirmed it runs on arm64 🎉 .

@WyriHaximus Would you mind updating the image in this PR and removing the architecture related part?

✔️

@linki linki merged commit c774eda into linki:master Jul 19, 2022
@linki
Copy link
Owner

linki commented Jul 19, 2022

@WyriHaximus Thanks a lot! Sorry it took so long.

@WyriHaximus WyriHaximus deleted the improve-helm-experience branch July 20, 2022 11:52
@WyriHaximus
Copy link
Contributor Author

@linki Cheers, and no worries. Life is always more important to work :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants