New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Helm experience #375
Conversation
@@ -45,7 +45,8 @@ INFO[4804] terminating pod name=nginx-701339712-51nt8 namespace=chaosku | |||
You can install `chaoskube` with [`Helm`](https://github.com/kubernetes/helm). Follow [Helm's Quickstart Guide](https://helm.sh/docs/intro/quickstart/) and then install the `chaoskube` chart. | |||
|
|||
```console | |||
$ helm install stable/chaoskube | |||
$ helm repo add chaoskube https://linki.github.io/chaoskube/ | |||
$ helm install chaoskube chaoskube/chaoskube --atomic --namespace=chaoskube --create-namespace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old instructions got me initially too. New instructions will be helpful for new users 👍
I was just tracking down why it is I can't get chaoskube to start in Dry Run mode, and this PR would fix it for me. Would help me a lot to get this in. Edit: For anyone else who is stuck you can use |
@WyriHaximus Thanks a lot for this PR. Meanwhile I migrated the docker images from @WyriHaximus Would you mind updating the image in this PR and removing the architecture related part? |
d2af3bf
to
871fce9
Compare
Since the deprecation of the `stable` Helm chart repository by Helm, chaoskube's chart is one of the charts I've been waiting for to be ported. Initially, when that happened I didn't get it to work and didn't look too deep into it. Now that I'm building a home cluster it came up again, and after looking into it properly there are a few things that came up: - [X] The project's readme still lists the old `stable` Helm chart repository. - [X] The chart's readme lists a non-existent (?) Helm chart repository - [X] Has default values for arguments causing issues for some of those when empty - [X] Missing `v` for the default tag P.S. This PR only aims to make it work out of the box again and contains some breaking changes causing the major version bump.
871fce9
to
e5e8d16
Compare
@linki 👍 , also rebased this PR on the latest master
Awesome, updated the chart with the new repository and confirmed it runs on
✔️ |
@WyriHaximus Thanks a lot! Sorry it took so long. |
@linki Cheers, and no worries. Life is always more important to work :). |
Since the deprecation of the
stable
Helm chart repository by Helm, chaoskube's chart is one of the charts I've been waiting for to be ported.Initially, when that happened I didn't get it to work and didn't look too deep into it. Now that I'm building a home cluster it came up again,
and after looking into it properly there are a few things that came up:
stable
Helm chart repository.v
for the default tagP.S. This PR only aims to make it work out of the box again and contains some breaking changes causing the major version bump.