Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generators should escape correctly @. #2110

Open
lu-zero opened this issue May 15, 2024 · 5 comments
Open

Generators should escape correctly @. #2110

lu-zero opened this issue May 15, 2024 · 5 comments
Labels
bug Something that should work but isn't, with an example and a test case. community-generated generator-misc Pertaining to more than one generator, or perhaps one that doesn't exist yet

Comments

@lu-zero
Copy link

lu-zero commented May 15, 2024

Describe the bug
Some targets do not accept @ as-is, so terms such as @id or @type have to be escaped/transformed.

To reproduce
Steps to reproduce the behavior:

Expected behavior
Every generator should have a mean to escape/map @terms.

@lu-zero lu-zero added the bug Something that should work but isn't, with an example and a test case. label May 15, 2024
@nlharris nlharris added community-generated generator-misc Pertaining to more than one generator, or perhaps one that doesn't exist yet labels May 17, 2024
@nlharris
Copy link
Contributor

@lu-zero perhaps you could propose a fix (as a PR)?

@lu-zero
Copy link
Author

lu-zero commented May 24, 2024

I'm not accustomed to the codebase so I do not know if you have already some way to do this kind of transformations in a centralized way.

@cmungall
Copy link
Member

Thanks for the report @lu-zero!

Yes, this isn't something to dive into lightly.

The URL you provided doesn't resolve, but I assume that you are working with some kind of JSON-LD. Are you sure you want to make a schema for the JSON-LD expanded form? See:

https://linkml.io/linkml/howtos/using-jsonld.html

@lu-zero
Copy link
Author

lu-zero commented May 24, 2024

It is here now https://github.com/w3c/wot-thing-description-toolchain-tmp/blob/main/resources/thing_description_schema.yaml

A Thing Description is somehow a jsonld with some constraints to make it bearable by json processors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that should work but isn't, with an example and a test case. community-generated generator-misc Pertaining to more than one generator, or perhaps one that doesn't exist yet
Projects
None yet
Development

No branches or pull requests

3 participants