You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.
It is fundamentally flawed to check for source.release if you can overwrite it in params.release
This cause all the current check to fail if you installed a chart and overwrite the release name with params.release.
I don't know what would be the best approach to fix that but you can't access params in check.
My current use case is PR generate multiple parallel runs of a pipeline. I need to namespace some stuff by commitID to avoid clashes. I don't know said commitID before so I overwrite the release name on put which causes the check to fail because the release in source doesn't exist. I think we should overall make the resource release agnostic by default (remove source.release) but then I have no idea what check we could perform..
The text was updated successfully, but these errors were encountered:
Typositoire
changed the title
check resource fails when source.release != params.release
check resource fails when source.release != params.releaseApr 18, 2019
Typositoire
changed the title
check resource fails when source.release != params.release
check resource fails when source.release != params.release
Apr 18, 2019
I use it the other way, for me only the source one is relevant. And ad you say there’s no way to check for the params release.
But I think you’ll never use it anyway, I can’t see a Pipeline where you use „dynamic“ releases and checks together so I suggest we add a flag to basically disable check.
It is fundamentally flawed to check for
source.release
if you can overwrite it inparams.release
This cause all the current check to fail if you installed a chart and overwrite the release name with
params.release
.I don't know what would be the best approach to fix that but you can't access
params
in check.My current use case is PR generate multiple parallel runs of a pipeline. I need to namespace some stuff by commitID to avoid clashes. I don't know said commitID before so I overwrite the release name on
put
which causes the check to fail because the release in source doesn't exist. I think we should overall make the resource release agnostic by default (remove source.release) but then I have no idea what check we could perform..The text was updated successfully, but these errors were encountered: