Skip to content
This repository has been archived by the owner on Aug 28, 2021. It is now read-only.

hide option not working anymore. #80

Closed
maandr opened this issue Jul 23, 2018 · 4 comments
Closed

hide option not working anymore. #80

maandr opened this issue Jul 23, 2018 · 4 comments
Assignees
Labels

Comments

@maandr
Copy link

maandr commented Jul 23, 2018

Lately the hide option does not work for me anymore, even when providing new type: string along with it.

    - put: k8s
      params:
        chart: git/my-helm-chart
        values: git/my-helm-chart/values.yaml
        namespace: ((k8s_namespace))
        release: my-release
        override_values:
        - key: database.password
          value: ((database_password))
          type: string
          hide: true

This configuration still prints the values of database.password in the logs.

@msiegenthaler
Copy link
Member

Oh, that happens on latest and 2.9.1-2, correct? Then it's probably a side-effect of the commit cfa5047 and the refactoring that was done there.

I'll look into it.

@maandr
Copy link
Author

maandr commented Jul 25, 2018

Yes, I first noticed it after cfa5047.

Thanks a lot!

@msiegenthaler
Copy link
Member

Ah, it was renamed to 'hidden' in error. I reverted it back to 'hide' in commit f8346a. Now it should work again.
Could you test it with head (wait a bit for my change to be built)?

@msiegenthaler msiegenthaler self-assigned this Jul 25, 2018
@maandr
Copy link
Author

maandr commented Jul 26, 2018

--set-string database.password=***HIDDEN*** 

Great. That fixed it. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants