Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev remove hardcoded language dependency from code #871

Closed
nevos opened this issue May 22, 2018 · 4 comments
Closed

dev remove hardcoded language dependency from code #871

nevos opened this issue May 22, 2018 · 4 comments
Assignees
Labels
2.0.4 dev More Info The developer needs more information in order to fix / implement
Milestone

Comments

@nevos
Copy link
Contributor

nevos commented May 22, 2018

search the code, and remove ANY hardcoded language dependency such as:

  •        if(lang === 'en'){	+            if(lang === 'he') {
    
  •            $event.target.children.length === 0 ? scrollLeft($event.target) : scrollLeft($event.target.firstChild);	
    
  •        } else if(lang === 'he') {
    
@nevos nevos added this to the 2.0.4 milestone May 22, 2018
@nevos
Copy link
Contributor Author

nevos commented May 22, 2018

@manmorc please do it on dev

@manmorc
Copy link
Contributor

manmorc commented May 22, 2018

#872

@nevos
Copy link
Contributor Author

nevos commented May 31, 2018

please fix as part of ltr/rtl sass mechanism

@nevos nevos reopened this May 31, 2018
@nevos nevos changed the title remove hardcoded language dependency from code dev remove hardcoded language dependency from code May 31, 2018
@manmorc
Copy link
Contributor

manmorc commented Jun 14, 2018

@nevos functionality from previous version, that showed the first part of long title was not imported, it was only place this language dependencies was used, it is needed to implement it again, but without language depends??

@manmorc manmorc added the More Info The developer needs more information in order to fix / implement label Jun 14, 2018
@manmorc manmorc closed this as completed Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0.4 dev More Info The developer needs more information in order to fix / implement
Projects
None yet
Development

No branches or pull requests

2 participants