Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstracting secret management from values repo PoC #263

Closed
9 tasks done
j-zimnowoda opened this issue Jan 4, 2021 · 5 comments
Closed
9 tasks done

Abstracting secret management from values repo PoC #263

j-zimnowoda opened this issue Jan 4, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@j-zimnowoda
Copy link
Contributor

j-zimnowoda commented Jan 4, 2021

**Is your feature request related to a problem? **

The current secret management implementation:

  • does not support multi tenancy, so a user can either decrypt all secrets or non of them.
  • enforces storing secrets in a separate files, what is a source of data management and data merge issues.

We need robust, multi-tenant secret management solution that integrates seamlessly with Kubernetes but also is suitable for GitOps approach. The solution should also provide secret rotations out of the box.

For more information see discussion: #279

Describe the solution you'd like
I would like to have vault a a secret manager.

First of of Valut seems to be a great candidate as it provides:

Unfortunately, it does not support secrets injection as ENV vars (link)

There are two solutions that could meet our requirements:

Related tasks:

  • prepare PoC and make a demo for a team
    • integrate vault operator chart from bank-vaults
    • integrate vault authentication OIDC with keycloak
    • expose vault service via public url
    • enforce vault secrets access control based on JWT groups claim
    • integrate kubernetes-extrenal-secrets project
    • integrate mutation webhook for injecting vault secrets directly to the container from bank-vaults
  • collect requirements
  • prepare user stories (in-progress)
@j-zimnowoda j-zimnowoda added the enhancement New feature or request label Jan 4, 2021
@j-zimnowoda j-zimnowoda self-assigned this Jan 4, 2021
@project-bot project-bot bot added this to Hot Issues in Otomi Container Platform Jan 4, 2021
@0-sv
Copy link
Contributor

0-sv commented Jan 4, 2021

Awesome. The tradeoff between kubernetes-external-secret and bank-vault seems tricky, they both seem to be maintained equally well. I guess bank-vault offers more features and has 50 more collaborators, but then again, the other project is created for solving this problem specifically, correct?

@j-zimnowoda
Copy link
Contributor Author

Indeed, choosing the one is tricky. Intuitively, I like more bank-vaults, because of it's simplicity in terms of referencing to a secret value. But let's make our hands dirty first and then we can decide which one does better work for us.

The kubernetes-external-secrets can integrate more seamlessly but if has some disadvantages that I would like to avoid.

@Morriz
Copy link
Contributor

Morriz commented Jan 5, 2021

I prefer bank-vaults as it fits more tightly. The other one is offering an interface that is too wide. So if the POC with bank-vaults feels nice we can just continue with that imo.

@j-zimnowoda j-zimnowoda moved this from Hot Issues to In Progress in Otomi Container Platform Jan 6, 2021
@j-zimnowoda
Copy link
Contributor Author

Yes, I am going to start with bank-vaults

@j-zimnowoda j-zimnowoda changed the title Abstract secret management from values repo Abstracting secret management from values repo Jan 27, 2021
@j-zimnowoda j-zimnowoda changed the title Abstracting secret management from values repo Abstracting secret management from values repo PoC Feb 7, 2021
Otomi Container Platform automation moved this from In Progress to Closed Feb 8, 2021
@j-zimnowoda
Copy link
Contributor Author

Discussion is finished. Requirements are complete and user stories defined.

@srodenhuis srodenhuis removed this from Closed in Otomi Container Platform Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants