Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new Linode Resize behavior #42

Closed
displague opened this issue Apr 10, 2019 · 1 comment
Closed

Adapt to new Linode Resize behavior #42

displague opened this issue Apr 10, 2019 · 1 comment

Comments

@displague
Copy link
Contributor

Resized Linodes now automatically resize the disk/filesystem to the full size of the disk under specific conditions (1 disk with up to 1 additional swap disk).

One of the tests is failing because of this change in behavior:

https://github.com/terraform-providers/terraform-provider-linode/blob/master/linode/resource_linode_instance_test.go#L676

Users may find that a change in the Instance type to a larger plan followed by a change to a smaller plan may fail. With the new behavior, the disk has been enlarged and is too large to be reduced back into the smaller plan.

The provider can address this by first attempting to reduce the size of disks before attempting to resize the instance.

In the case of an Instance with "disks" and "configs", changing the disk size should be left to the user and would require that https://github.com/terraform-providers/terraform-provider-linode/issues/13 be resolved.

In the case of an Instance using the "simple" configuration (no "disks" or "configs") the provider should attempt to resize the first disk by the disk size difference between the source and target instance types.

@ellisbenjamin
Copy link
Contributor

This has been resolved in PR 55:

https://github.com/terraform-providers/terraform-provider-linode/blob/master/linode/resource_linode_instance.go#L1170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants