Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrest SQL generated for order by contains column #2749

Merged
merged 2 commits into from Jan 1, 2021
Merged

Incorrest SQL generated for order by contains column #2749

merged 2 commits into from Jan 1, 2021

Conversation

MaceWindu
Copy link
Contributor

not all providers support IN as predicate (list below)
also minor issue - contains result not selected, but re-evaluated on server

 SELECT
    	[_].[PersonID],
    	[_].[LastName]
    FROM
    	[Person] [_]
    ORDER BY
    	[_].[PersonID] IN (1, 3)

Fails for:

  • Firebird 2.5 (works in 3.0). Note that I'm working on versioning support for firebird so it makes sense to preserve 3.0 behavior (maybe commented for now)
  • oracle (at least v11), need to test v12 on CI
  • SAP HANA
  • SQL Server
  • SQL CE
  • Sybase ASE

@MaceWindu MaceWindu added this to the 3.2.3 milestone Dec 31, 2020
@MaceWindu
Copy link
Contributor Author

/azp run test-oracle

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu MaceWindu changed the title Incorrest SQL generated for order by contains Incorrest SQL generated for order by contains column Dec 31, 2020
@sdanyliv
Copy link
Member

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@linq2dbot linq2dbot mentioned this pull request Dec 31, 2020
Merged
@linq2dbot
Copy link

Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed.

@MaceWindu MaceWindu marked this pull request as ready for review January 1, 2021 11:22
@MaceWindu MaceWindu merged commit bcf4ad3 into master Jan 1, 2021
@MaceWindu MaceWindu deleted the issue/order_by_contains branch January 1, 2021 11:30
MaceWindu pushed a commit to linq2db/linq2db.baselines that referenced this pull request Jan 1, 2021
@linq2dbot
Baselines for linq2db/linq2db#2749 (#508)
de76aa1 
* [Windows / NET472 / Access ACE] baselines

* [Windows / NET472 / Access ODBC ACE] baselines

* [Windows / NET472 / SQL CE] baselines

* [Windows / NET 5.0 / SQL Server 2019 (Microsoft.Data.SqlClient)] baselines

* [Windows / NET472 / SQLite.MS] baselines

* [Windows / NET5.0 / SQLite] baselines

* [Windows / NET472 / SQL Server 2019 (System.Data.SqlClient)] baselines

* [Windows / NET472 / SQL Server 2005 (System.Data.SqlClient)] baselines

* [Windows / NETCOREAPP2.1 / SQL CE] baselines

* [Windows / NET472 / SQL Server 2008 (System.Data.SqlClient)] baselines

* [Windows / NET472 / SQL Server 2019 (Microsoft.Data.SqlClient)] baselines

* [Windows / NET472 / SQL Server 2012 (System.Data.SqlClient)] baselines

* [Windows / NET472 / SQLite] baselines

* [Windows / NETCOREAPP2.1 / SQLite.MS] baselines

* [Windows / NETCOREAPP2.1 / Access ODBC ACE x64] baselines

* [Windows / NET472 / SQL Server 2016 (System.Data.SqlClient)] baselines

* [Linux / NETCOREAPP2.1 / DB2 LUW 11.5] baselines

* [Linux / NETCOREAPP2.1 / Informix 14.10] baselines

* [Windows / NET472 / SQL Server 2014 (System.Data.SqlClient)] baselines

* [Windows / NET472 / SQL Server 2017 (System.Data.SqlClient)] baselines

* [Linux / NETCOREAPP3.1 / PostgreSQL] baselines

* [Linux / NET5.0 / PostgreSQL 13] baselines

* [Linux / NETCOREAPP3.1 / MySQL] baselines

* [Linux / NETCOREAPP2.1 / Firebird 2.5] baselines

* [Windows / NETCOREAPP2.1 / SQL Server 2005 (System.Data.SqlClient)] baselines

* [Linux / NET5.0 / SQL Server 2019 (Microsoft.Data.SqlClient)] baselines

* [Windows / NETCOREAPP2.1 / SQL Server 2008 (System.Data.SqlClient)] baselines

* [Linux / NETCOREAPP2.1 / MySQL 5.5] baselines

* [Windows / NETCOREAPP2.1 / SQL Server 2012 (System.Data.SqlClient)] baselines

* [Linux / NETCOREAPP2.1 / MariaDB] baselines

* [Windows / NETCOREAPP2.1 / SQL Server 2017 (System.Data.SqlClient)] baselines

* [Linux / NETCOREAPP2.1 / Firebird 3.0] baselines

* [Windows / NETCOREAPP2.1 / SQL Server 2016 (System.Data.SqlClient)] baselines

* [Linux / NETCOREAPP2.1 / PostgreSQL 11] baselines

* [Linux / NETCOREAPP2.1 / PostgreSQL 10] baselines

* [Windows / NETCOREAPP2.1 / SQL Server 2014 (System.Data.SqlClient)] baselines

* [Linux / NETCOREAPP2.1 / PostgreSQL 12] baselines

* [Linux / NETCOREAPP2.1 / PostgreSQL 9.2] baselines

* [Linux / NETCOREAPP2.1 / PostgreSQL 9.5] baselines

* [Linux / NETCOREAPP2.1 / PostgreSQL 9.3] baselines

* [Linux / NETCOREAPP2.1 / SQL Server 2017 (System.Data.SqlClient)] baselines

* [Linux / NETCOREAPP2.1 / Sybase ASE 16] baselines

* [Linux / NETCOREAPP2.1 / Oracle 12c] baselines

* [Linux / NETCOREAPP2.1 / SAP HANA 2] baselines

Co-authored-by: Azure Pipelines Bot <azp@linq2db.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
severity: regression
Milestone
3.2.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MaceWindu @sdanyliv @linq2dbot