Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[oracle 12+] Test native identity support in bulk copy #3245

Merged
merged 3 commits into from Oct 13, 2021
Merged

[oracle 12+] Test native identity support in bulk copy #3245

merged 3 commits into from Oct 13, 2021

Conversation

MaceWindu
Copy link
Contributor

@MaceWindu MaceWindu commented Oct 9, 2021 •
edited

Fix #3239

No actual fixes here:

  • added tests for sequence-based identity column insert in all modes for Oracle (requires oracle12+)
  • documented various modes for MultipeRows bulk copy for Oracle

Following modes are not supported (due to oracle or oracle provider limitations):

  • native (provider-specific) bulk copy with identity generation: no identity generated by provider (or db?)
  • MultipleRows with InsertAll mode with identity generation: oracle limitation of INSERT ALL statement - only one sequence value generated and used for all rows
  • RowByRow with provided identity value: general limitation of linq2db bulk copy API, applied to all providers

@MaceWindu MaceWindu added this to the 3.5.0 milestone Oct 9, 2021
@MaceWindu
Copy link
Contributor Author

/azp run test-oracle

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
- document AlternativeBulkCopy
86f6e22 
- cleanup oracle bulk copy tests
@MaceWindu
Copy link
Contributor Author

/azp run test-oracle

@MaceWindu MaceWindu marked this pull request as ready for review October 9, 2021 13:54
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu MaceWindu changed the title [oracle 12+] Improve native identity support in bulk copy [oracle 12+] Test native identity support in bulk copy Oct 9, 2021
@MaceWindu MaceWindu modified the milestones: 3.5.0, 3.4.6 Oct 9, 2021
@linq2dbot linq2dbot mentioned this pull request Oct 9, 2021
Merged
@linq2dbot
Copy link

Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed.

@MaceWindu
Copy link
Contributor Author

/azp run test-oracle

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu MaceWindu merged commit 1f14576 into master Oct 13, 2021
@MaceWindu MaceWindu deleted the issue/3239 branch October 13, 2021 12:57
MaceWindu pushed a commit to linq2db/linq2db.baselines that referenced this pull request Oct 13, 2021
@linq2dbot
Baselines for linq2db/linq2db#3245 (#682)
8974bec 
* [Linux / NETCOREAPP2.1 / Oracle 11g XE] baselines

* [Linux / NETCOREAPP2.1 / Oracle 12c] baselines

Co-authored-by: Azure Pipelines Bot <azp@linq2db.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdanyliv sdanyliv sdanyliv approved these changes

@viceroypenguin viceroypenguin viceroypenguin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

BulkCopy with Identity column in Oracle
4 participants
@MaceWindu @linq2dbot @sdanyliv @viceroypenguin