Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V5]Lower dependency versions for microsoft abstraction libs #3953

Closed
nsarris opened this issue Feb 5, 2023 · 1 comment · Fixed by #3955
Closed

[V5]Lower dependency versions for microsoft abstraction libs #3953

nsarris opened this issue Feb 5, 2023 · 1 comment · Fixed by #3955
Assignees
Milestone

Comments

@nsarris
Copy link
Contributor

nsarris commented Feb 5, 2023

Linq2db uses DependencyInjection and Logging abstractions from the MS extensions namespace. It is generally not the best practive to aggresively upgrade those packages in library projects as they are pretty much backwards compatible back to v1 and might create conflicts to consumer projects. Linq2db only uses IServiceCollection and ILoggerFactory / ILogger , you can stay to a very early version of abstractions for both or at least stick to v6.

@MaceWindu
Copy link
Contributor

linq2db itself don't use them, but it is referenced by linq2db.aspnet project.

As this issue was rised second time in last couple of months, I think we can do it in v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants