Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EntityDescriptorCreatedCallback to options #3969

Merged
merged 7 commits into from Feb 14, 2023
Merged

Conversation

MaceWindu
Copy link
Contributor

@MaceWindu MaceWindu commented Feb 13, 2023

Fix #1592
Fix #1822

With this fix user could define:

  • application-wide callback using MappingSchema.EntityDescriptorCreatedCallback static property (was instance before fix)
  • context-level option using WithOnEntityDescriptorCreated/UseOnEntityDescriptorCreated configuration extensions

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Tests/Linq/UserTests/Issue1128Tests.cs Outdated Show resolved Hide resolved
Source/LinqToDB/Mapping/MappingSchema.cs Outdated Show resolved Hide resolved
@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

igor-tkachev
igor-tkachev previously approved these changes Feb 13, 2023
viceroypenguin
viceroypenguin previously approved these changes Feb 13, 2023
@linq2dbot
Copy link

Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed.

sdanyliv
sdanyliv previously approved these changes Feb 13, 2023
@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@linq2dbot
Copy link

Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed.

@MaceWindu MaceWindu merged commit 738fd90 into master Feb 14, 2023
MaceWindu pushed a commit to linq2db/linq2db.baselines that referenced this pull request Feb 14, 2023
* [Linux / PostgreSQL 10] baselines

* [Linux / PostgreSQL 11] baselines

* [Linux / PostgreSQL 12] baselines

* [Linux / PostgreSQL 14] baselines

* [Linux / PostgreSQL 15] baselines

* [Linux / PostgreSQL 13] baselines

* [Linux / Oracle 11g XE] baselines

---------

Co-authored-by: Azure Pipelines Bot <azp@linq2db.com>
@MaceWindu MaceWindu deleted the issue/1592 branch February 14, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

EntityDescriptorCreatedCallback not working MappingSchema.EntityDescriptorCreatedCallback should be static
5 participants