Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose of generic argument in IMetadataReader.GetAttributes<T> #3981

Closed
nsarris opened this issue Feb 20, 2023 · 2 comments · Fixed by #3982
Closed

Purpose of generic argument in IMetadataReader.GetAttributes<T> #3981

nsarris opened this issue Feb 20, 2023 · 2 comments · Fixed by #3982
Labels
status: has-pr There is active PR for issue type: refactoring
Milestone

Comments

@nsarris
Copy link
Contributor

nsarris commented Feb 20, 2023

Is there any puprpose in the generic attributte in IMetadataReader.GetAttributes after the attriutes refactoring? Unless I missed something the framework internally only calls IMetadataReader.GetAttributes and I don't see IMetadataReader as part of the public API. Even so it's a minor breaking change, the consumer can simply filter the results with. This would simplify the implementation of provider implementations and remove a lot of type checking.

@MaceWindu
Copy link
Contributor

MaceWindu commented Feb 20, 2023

That's actually makes sense... We plan to release final version this week, so we should do it now or leave it as it is ..

@MaceWindu MaceWindu added this to the 5.0.0 milestone Feb 20, 2023
@nsarris
Copy link
Contributor Author

nsarris commented Feb 20, 2023

I vote for now if you could sqeeze it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: has-pr There is active PR for issue type: refactoring
Development

Successfully merging a pull request may close this issue.

2 participants