Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(path): resolve symlink in Windows #75

Merged
merged 8 commits into from
Oct 20, 2023
Merged

fix(path): resolve symlink in Windows #75

merged 8 commits into from
Oct 20, 2023

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Oct 20, 2023

Thanks to your contribute, while please finish below tasks:

Regression Test

Platforms

  • windows
  • macOS
  • linux

Tasks

  • Use <leader>gl to copy git link.
  • Use <leader>gL to open git link in browser.
  • Copy git link in a symlink directory of git repo.
  • Copy git link in an un-pushed git branch, and receive an expected error.
  • Copy git link in a pushed git branch but edited file, and receive a warning says the git link could be wrong.

@github-actions github-actions bot added the fix label Oct 20, 2023
@linrongbin16 linrongbin16 changed the title fix(path): resolve symlink in Windows #95 fix(path): resolve symlink in Windows Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Files Coverage Δ
lua/gitlinker/logger.lua 90.32% <100.00%> (-0.73%) ⬇️
lua/gitlinker/spawn.lua 78.90% <100.00%> (+0.33%) ⬆️
lua/gitlinker.lua 37.90% <0.00%> (ø)
lua/gitlinker/git.lua 10.79% <0.00%> (+0.65%) ⬆️
lua/gitlinker/util.lua 16.27% <11.53%> (+5.16%) ⬆️

📢 Thoughts on this report? Let us know!.

@linrongbin16 linrongbin16 merged commit b292a4f into master Oct 20, 2023
10 checks passed
@linrongbin16 linrongbin16 deleted the refactor4 branch October 20, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant