Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] provide option to disable progress #1295

Closed
tjx666 opened this issue May 8, 2023 · 7 comments
Closed

[Feature] provide option to disable progress #1295

tjx666 opened this issue May 8, 2023 · 7 comments

Comments

@tjx666
Copy link

tjx666 commented May 8, 2023

You can see there are may useless log in ci output when lint failed:

image

@tjx666
Copy link
Author

tjx666 commented May 11, 2023

or we should auto simplify the output when we detect lint-staged is running under ci by https://www.npmjs.com/package/ci-info

@DamienCassou
Copy link

I would like this as well but outside of CI so a --no-progress would be useful.

@tjx666
Copy link
Author

tjx666 commented Oct 12, 2023

for anyone using in ci, can ref: https://github.com/tjx666/fe-scripts/blob/main/lint-changed.ts

@iiroj
Copy link
Member

iiroj commented Oct 12, 2023

How about using the existing --quiet flag?

@iiroj
Copy link
Member

iiroj commented Oct 12, 2023

We could add some CI checks here to enable the verbose logger:

https://github.com/okonet/lint-staged/blob/50cc3cc1e0baa1d45907c7520c654a5851fd4fc8/lib/getRenderer.js#L34-L39

@tjx666
Copy link
Author

tjx666 commented Oct 13, 2023

--quiet normally means dont't output anything.

@iiroj
Copy link
Member

iiroj commented Oct 24, 2023

Looking at the initial screenshot a bit more, this looks like an issue of: https://github.com/lint-staged/lint-staged?tab=readme-ov-file#the-output-of-commit-hook-looks-weird-no-colors-duplicate-lines-

Can you try updating your git to the latest version? I'll close this issue but feel free to re-open.

@iiroj iiroj closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants