stylefmt example broken for multiple files

[richardgill]

Here is a minimal example: https://github.com/richardgill/lint-staged-stylefmt-bug-example

stylefmt doesn't accept multiple files on the command line. Looks like there used to be a --list parameter, but it's not longer there.

Using --recursive works for me via npm run but doesn't work with lint-staged. I think I am seeing an additional -- getting added to the command which messes with stylefmt.

Note that is only an issue for when you break the css for multiple files (add spaces before the }'s to test. I think it works ok for one file.

Could you confirm that lint-staged is adding an extra -- and once I full understand what's going on. We can raise an issue with stylefmt.

Thanks,

[okonet]

Yes, as of https://github.com/okonet/lint-staged/blob/master/src/findBin.js#L6

That's needed to be able to pass arguments to npm tasks. See https://docs.npmjs.com/cli/run-script

[okonet]

Is this related to #138?

[richardgill]

#138 would solve this usecase I think

stylefmt -r '${ paths }'would work (maybe without the 's)

It was also really difficult to figure out that -- was getting called I've commented here about that in #161

In the past I've manually added the --. I see it mentioned in the docs now I look for it, must have missed it!

I actually thing #138 would be how I'd do things by default, it means a new comer is more likely to understand what's going on.

Thanks for the library. It's saving my team and I loads of time!

[okonet]

Yeah, good suggestion to make it default. I don't know if this will be too verbose though. If you have multiple commands it might become a pain to setup.

[chaucerbao]

I believe I've been running into this issue lately. Just wondering if there was a working solution around it until a fix is implemented.

It's been overwriting random files, possibly because the first argument for stylefmt is input-name and the second is output-name.

Usage: stylefmt [options] input-name [output-name]

[chaucerbao]

The workaround I'm using to account for -- with stylefmt is:

// package.json
...
  "lint-staged": {
    "*.scss": [
      "npm run stylefmt",
      "stylelint",
      "git add"
    ]
  },
  "scripts": {
    "stylefmt": "stylefmt --recursive"
  },
...

[okonet]

@chaucerbao just FYI you might not need this workaround with the latest version since it removes the addition of -- for non-npm tasks. See #196

[chaucerbao]

@okonet Confirmed that it works. Thanks!