-
-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to use node binary in Windows. #292
Comments
Hey @Ailrun, could you please share your lint-staged config? |
@sudo-suhas Actually, it occurs when I try to run https://github.com/kentcdodds/kcd-scripts |
I have not used |
@sudo-suhas I try to contribute to https://github.com/paypal/glamorous, which use |
I followed the linked issue and took a look at this - https://github.com/kentcdodds/kcd-scripts/blob/master/src/config/lintstagedrc.js. I think this issue can be fixed with a |
I am on windows too and being able to test our changes against a package helps. |
@sudo-suhas Hm... I will try to make an example repo, if time allows.. |
@Ailrun No need, I can use https://github.com/paypal/glamorous. |
Continuing this discussion in https://github.com/kentcdodds/kcd-scripts as it is not a lint-staged issue as far as I can tell. |
Following code breaks windows path like
C:\\Program Files (x86)\\Nodist\\v-x64\\8.2.1\\node.exe
.https://github.com/okonet/lint-staged/blob/58ea81805272acd89bf23c98b8c1a88ad343456d/src/findBin.js#L35
The text was updated successfully, but these errors were encountered: