Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to use node binary in Windows. #292

Closed
Ailrun opened this issue Sep 19, 2017 · 9 comments
Closed

Fails to use node binary in Windows. #292

Ailrun opened this issue Sep 19, 2017 · 9 comments

Comments

@Ailrun
Copy link

Ailrun commented Sep 19, 2017

Following code breaks windows path like C:\\Program Files (x86)\\Nodist\\v-x64\\8.2.1\\node.exe.

https://github.com/okonet/lint-staged/blob/58ea81805272acd89bf23c98b8c1a88ad343456d/src/findBin.js#L35

@sudo-suhas
Copy link
Collaborator

Hey @Ailrun, could you please share your lint-staged config?

@Ailrun
Copy link
Author

Ailrun commented Sep 19, 2017

@sudo-suhas Actually, it occurs when I try to run https://github.com/kentcdodds/kcd-scripts

@sudo-suhas
Copy link
Collaborator

I have not used kcd-scripts before and am not clear on how you would use it. Could you please share your package.json? I might be able to help you so that lint-staged runs okay.

@Ailrun
Copy link
Author

Ailrun commented Sep 19, 2017

@sudo-suhas I try to contribute to https://github.com/paypal/glamorous, which use kcd-scripts, which use lint-staged, ...

@sudo-suhas
Copy link
Collaborator

I followed the linked issue and took a look at this - https://github.com/kentcdodds/kcd-scripts/blob/master/src/config/lintstagedrc.js. I think this issue can be fixed with a path.isAbsolute(cmd) check. @okonet What do you think?

@sudo-suhas
Copy link
Collaborator

I try to contribute https://github.com/paypal/glamorous, which use kcd-scripts, which use lint-staged, ...

I am on windows too and being able to test our changes against a package helps.

@Ailrun
Copy link
Author

Ailrun commented Sep 19, 2017

@sudo-suhas Hm... I will try to make an example repo, if time allows..

@sudo-suhas
Copy link
Collaborator

@Ailrun No need, I can use https://github.com/paypal/glamorous.

@sudo-suhas
Copy link
Collaborator

Continuing this discussion in https://github.com/kentcdodds/kcd-scripts as it is not a lint-staged issue as far as I can tell.

@Ailrun Ailrun closed this as completed Sep 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants