Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarball dependency on listr-update-renderer breaks npm audit #516

Closed
YannickMeeus opened this issue Oct 29, 2018 · 1 comment
Closed

Tarball dependency on listr-update-renderer breaks npm audit #516

YannickMeeus opened this issue Oct 29, 2018 · 1 comment

Comments

@YannickMeeus
Copy link

Description

As part of the update to lint-staged 8.0.0, a dependency was taken on a version of listr-update-renderer not hosted in npm, but instead pulled from GitHub. This has the unfortunate side-effect that due to an issue described here (npm.community.net) and here (github.com/npm) npm audit no longer works.

I understand this very well looks like an issue that needs to be fixed in npm, but I just wanted to give you the heads-up that this is a thing, and the only workaround so far is to temporarily remove lint-staged, then npm i && npm audit fix, to then put the dependency back, which isn't great but not the end of the world either. But until either the NPM lot passes down a fix or the tarball dependency turns into an npm dependency, npm audit will not work in conjunction with lint-staged.

Steps to reproduce

N/A

Environment

  • OS: macOS Mojave
  • Node.js: v11.0.0
  • lint-staged: 8.0.0
@okonet
Copy link
Collaborator

okonet commented Oct 29, 2018

Duplicate of #511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants