Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if updateStash step is needed #528

Closed
okonet opened this issue Oct 30, 2018 · 2 comments · Fixed by #724
Closed

Check if updateStash step is needed #528

okonet opened this issue Oct 30, 2018 · 2 comments · Fixed by #724
Labels
enhancement help wanted released on @beta released

Comments

@okonet
Copy link
Collaborator

okonet commented Oct 30, 2018 •
edited

If updateStash is run on same tree, it is producing the error: unrecognized input error during restoration process. I assume it's because the patch is empty. This doesn't prevent lint-staged from functioning properly but it would be better to clean this up.

We should check if the updateStash step is a no-op by comparing trees SHAs.

See #522 (comment) for logs
@okonet okonet self-assigned this Oct 30, 2018
@okonet okonet removed their assignment Oct 30, 2018
@iiroj iiroj mentioned this issue Sep 25, 2019
Merged
3 tasks
@okonet
Copy link
Collaborator Author

okonet commented Oct 31, 2019

🎉 This issue has been resolved in version 9.5.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iiroj iiroj mentioned this issue Nov 20, 2019
Merged
@okonet
Copy link
Collaborator Author

okonet commented Jan 19, 2020

🎉 This issue has been resolved in version 10.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted released on @beta released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use git stashes in git workflow for better performance lint-staged/lint-staged
1 participant
@okonet